issue_comments: 778706122

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4904#issuecomment-778706122 https://api.github.com/repos/pydata/xarray/issues/4904 778706122 MDEyOklzc3VlQ29tbWVudDc3ODcwNjEyMg== 5635139 2021-02-14T01:38:15Z 2021-02-14T01:38:15Z MEMBER

Thanks a lot @rhkleijn , this is very impressive! The results look great. The __init_subclass__ approach seems dominant over our existing approach.

Did you ever consider replacing the injections with this macro-like approach to writing out the python methods, rather than using the macro to generate the stub files? (I don't bring this up with a view that it's better, but the injections have always seemed awkward)

Is there anything we should be aware of around the interactions between stub files and inline definitions?

Others will have useful thoughts too, so would be interested to hear from them too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   807764700