issue_comments: 773300501

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4858#issuecomment-773300501 https://api.github.com/repos/pydata/xarray/issues/4858 773300501 MDEyOklzc3VlQ29tbWVudDc3MzMwMDUwMQ== 10194086 2021-02-04T13:23:59Z 2021-02-04T13:23:59Z MEMBER

Thanks for the other examples. Yes these now also raise an error with numpy 1.20. What still does not raise is the following

python arr[0, 0] = np.nan (because this gets converted to da.variable._data[0:1, 0:1] = np.array([np.nan]) (approximately).

My suggestion is:

  1. replace the example with arr.pad(x=1, constant_values=1.23456789) and mention that the float is cast to int (or would you leave the example away?)
  2. open a new issue to discuss the issue of assigning float to int
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   800118528