issue_comments: 770388498
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/4849#issuecomment-770388498 | https://api.github.com/repos/pydata/xarray/issues/4849 | 770388498 | MDEyOklzc3VlQ29tbWVudDc3MDM4ODQ5OA== | 35968931 | 2021-01-31T14:12:12Z | 2021-01-31T14:12:12Z | MEMBER | This is great, thanks for submitting this! I just had a go with it, and it worked nicely. I have a couple of suggestions for improving it though: 1) Different fit coefficients as differently-named variables in the output, rather than indexed with a coordinate. This would then be consistent with
2) Initial guesses for each fit parameter. At the moment the user has to pass an ordered array of initial guesses through like
3) (Stretch goal) Ability to fit >1D functions, e.g. fit a 2D gaussian to find a peak in a 2D image. But if we get the API right then this could be left to a later PR. Also, the whole argument inspection thing probably deserves a few dedicated tests, in addition to testing the fitting functionality. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
797302408 |