home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 766669784

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3232#issuecomment-766669784 https://api.github.com/repos/pydata/xarray/issues/3232 766669784 MDEyOklzc3VlQ29tbWVudDc2NjY2OTc4NA== 98330 2021-01-25T09:12:51Z 2021-01-25T09:12:51Z NONE

Does this mean I shouldn't fill out __array_function__ in my subclass? Or is this just a forward looking expectation?

No, adding it should be perfectly fine. The dispatch mechanism itself isn't going anywhere, it's part of numpy and it works. Whether or not torch.Tensor itself has an __array_function__ method isn't too relevant for your subclass.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  482543307
Powered by Datasette · Queries took 0.653ms · About: xarray-datasette