home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 766166088

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4821#issuecomment-766166088 https://api.github.com/repos/pydata/xarray/issues/4821 766166088 MDEyOklzc3VlQ29tbWVudDc2NjE2NjA4OA== 5635139 2021-01-23T19:26:54Z 2021-01-23T19:26:54Z MEMBER

I would propose we either: - Explicitly allow tuples as dimension and variable names. This is probably the most mypy-compatible, since we use Hashable in lots of places - Force dimension names to be strings, but allow variable names to be Hashable. This might be the most practical. - Disallow tuples for dimension names, but otherwise allow Hashable. Then tuples work the same as lists when supplied as arguments.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  787847449
Powered by Datasette · Queries took 0.529ms · About: xarray-datasette