issue_comments: 765741719

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4826#issuecomment-765741719 https://api.github.com/repos/pydata/xarray/issues/4826 765741719 MDEyOklzc3VlQ29tbWVudDc2NTc0MTcxOQ== 463809 2021-01-22T23:27:57Z 2021-01-22T23:27:57Z CONTRIBUTOR

Apparently my proposed fix broke a bunch of other things, eg. some writing of timedeltas with units and such.

Deleting the "dtype" key in the .encoding of the boolean variable also seems to do the trick. The issue is that bools are not encoded correctly if the .encoding field already has a dtype:

https://github.com/pydata/xarray/blob/v0.16.2/xarray/conventions.py#L119

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   789410367