issue_comments: 76448604

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/337#issuecomment-76448604 https://api.github.com/repos/pydata/xarray/issues/337 76448604 MDEyOklzc3VlQ29tbWVudDc2NDQ4NjA0 2443309 2015-02-27T18:44:55Z 2015-02-27T18:44:55Z MEMBER

@shoyer: I just ran the example and it still works without any modifications.

A few comments/questions: - Should season be listed in the "virtual variables" here: http://xray.readthedocs.org/en/latest/data-structures.html - With the addition of the nan-safe functions, numpy is throwing a lot of warnings for things like "empty slices" (ocean grid cells in my example never have data). Its not a big deal to silence them but it is a bit annoying. - Since ds.groupby('time.season').mean('time') returns a Dataset with a Coordinates variable named time.season, ds.sel(time.season='JJA') doesn't work for Python syntax reasons. So, I don't know if I would change the syntax used in my example (selecting my position). I'm not keen on this constructor: ds.sel(**{'time.season':'JJA'}). I'm wondering if it would be better to name the coordinates returned from "virtual variable" operations without the "time." portion. Just a thought.

I will still get you an updated version of the example.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   59032389