home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 762899193

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2844#issuecomment-762899193 https://api.github.com/repos/pydata/xarray/issues/2844 762899193 MDEyOklzc3VlQ29tbWVudDc2Mjg5OTE5Mw== 2448579 2021-01-19T15:03:02Z 2021-01-19T15:03:02Z MEMBER

there were some substantial concerns about backwards compatibility

:( yes this is currently backward incompatible (so the next release will bump major version). There's reluctance to add yet another decode_* kwarg to open_dataset, and also reluctance to issue a warning saying that the behaviour of decode_coords will change in a future version (since this would be very common).

One option is to change decode_coords from bool to Union[bool, str] and allow decode_coords to be either "all" (this PR) or "coordinates", or True ( == "coordinates", backwards compatible). I can bring this up at the next dev meeting.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  424265093
Powered by Datasette · Queries took 73.561ms · About: xarray-datasette