issue_comments: 759780514

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4804#issuecomment-759780514 https://api.github.com/repos/pydata/xarray/issues/4804 759780514 MDEyOklzc3VlQ29tbWVudDc1OTc4MDUxNA== 10194086 2021-01-13T22:32:47Z 2021-01-14T01:15:02Z MEMBER

@aaronspring I had a quick look at your version - do you have an idea why it is is faster? Does yours also work for dask arrays?

  • In a, b = xr.broadcast(a, b, exclude=dim) why can you exclude dim?
  • I think you could also use a, b = xr.align(a, b, exclude=dim) (broadcast has join="outer" which fills it with NA which then get ignored; align uses join="inner")
  • Does your version work if the weights contain NA?
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   785329941