issue_comments: 752286931

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4740#issuecomment-752286931 https://api.github.com/repos/pydata/xarray/issues/4740 752286931 MDEyOklzc3VlQ29tbWVudDc1MjI4NjkzMQ== 14371165 2020-12-30T00:36:24Z 2020-12-30T00:36:24Z MEMBER

Looking good!

One thing I notice now with these changes is that ndim is now creeping up as the 2nd worst time consumer:

An easy improvement to this is adding ndim = var.ndim and replacing all the var.ndim around interp_func. That reduces the number of calls from 68000 to 58000. Another more difficult idea is to improve the dask arrays shape-calculation. Perhaps saving the value and only do the cached_cumsum call when the chunks actually has changed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   776042664