issue_comments: 745155086

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4682#issuecomment-745155086 https://api.github.com/repos/pydata/xarray/issues/4682 745155086 MDEyOklzc3VlQ29tbWVudDc0NTE1NTA4Ng== 12115839 2020-12-15T09:08:52Z 2020-12-15T09:08:52Z NONE

Yes in this case I need the functionality to be able to specify an alternative value similar to np.where so DataArray.where does not help me in this instance. But nevertheless this is a helpful insight.

Actually I am probably not really qualified to answer your question about adding kwargs or getting the value from the options since I am not really familiar with xarray code. While searching for the reason/solution to my problem I also came across the issues you mentioned and then just had a quick glance at the code why xr.where does not keep the attributes.

Anyway as far as I can see if xr.where would just have a **kwargs argument not keep_attrs specifically this would not directly break anything but would allow to pass any keyword argument of apply_ufunc and it would just be "handed" down. On the other side I can see the advantage of the options since this would keep the handling of keeping attributes consistent with existing code.

Long story short; it would be nice for users to at least be able to have a choice to keep attributes with this kind of operations (I guess there are other operations which have the same problem) regardless of how it is implemented.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   762385879