issue_comments: 743924206

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4672#issuecomment-743924206 https://api.github.com/repos/pydata/xarray/issues/4672 743924206 MDEyOklzc3VlQ29tbWVudDc0MzkyNDIwNg== 14808389 2020-12-13T00:13:02Z 2020-12-13T17:09:36Z MEMBER

locally on windows I find no large difference between numba 0.51 and 0.52

that's really strange. Why do we see that much of a speed-up once we downgrade numba on azure pipelines?

there are about 750 xfailed tests in test_units.py

yes, I will have to update those. I think until the index refactor we can safely skip all tests that rely on units in indexes, which should improve the situation, and there might also be a few tests that were fixed by pint.

Edit: see #4685

What is the difference between pytest.mark.xfail and pytest.xfail?

I think pytest.mark.xfail is the official way to decorate test functions while pytest.xfail can be used in the function body to programmatically mark the test as expected failure (which allows more control than the mark)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   761270240