home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 73815254

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/319#issuecomment-73815254 https://api.github.com/repos/pydata/xarray/issues/319 73815254 MDEyOklzc3VlQ29tbWVudDczODE1MjU0 1794715 2015-02-11T00:39:55Z 2015-02-11T00:39:55Z CONTRIBUTOR

seems like for, e.g., head, you can pass either a single dimension or multiple ones (e.g., either as **kwargs or a dictionary) and use those as the start dimension.

that said, about naming conventions, i think for tensors the most common convention is definitely slice() (which is implemented as isel). head/tail can be implemented in terms of slice().

e.g.: ds.slice(dim1=3, dim2=(1,4), dim3=(1,None,5)) -- or -- ds.slice({'dim1': 3, 'dim2': (1,4), 'dim3': (1, None, 5)})

head/tail/whatever are easy calls to this and you can have that in the documentation. as a result, people won't get confused because they understand slice.

On Tue, Feb 10, 2015 at 4:14 PM, Stephan Hoyer notifications@github.com wrote:

@ebrevdo https://github.com/ebrevdo yes, I think we probably need to stick to the pandas/numpy convention for the meaning of take.

My inspiration for these names was the head() and tail() methods in pandas, which are quite convenient. But it's not entirely clear how/if these generalize cleanly to N-dimensions. I suppose take_first and take_last could be an improvement over head/tail.

— Reply to this email directly or view it on GitHub https://github.com/xray/xray/issues/319#issuecomment-73812481.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  57254455
Powered by Datasette · Queries took 0.664ms · About: xarray-datasette