issue_comments: 735003978

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3356#issuecomment-735003978 https://api.github.com/repos/pydata/xarray/issues/3356 735003978 MDEyOklzc3VlQ29tbWVudDczNTAwMzk3OA== 5635139 2020-11-27T22:36:07Z 2020-11-29T01:36:57Z MEMBER

I took another pass at this:

  • When a DataArray is passed:
  • If it's > 1D, it's added as a non-dimension coordinate [is this right? what if it's name is the same as a dimension?]
  • If it's 1D and its name and dimension match, it's added as a dimensioned coordinate on that dimension
  • If it's 1D and its name and dimension don't match, it's added as a non-dimensiode coordinate
  • When something list-like is passed — and so is 1D — it's added as a dimensioned coordinate on that dimension [possibly this can be compressed to something like "list-like is initially transformed to a DataArray with a matching dimension & name]

Note that I haven't tested these, so may well not be correct.

I think this might fit into the assign_coords docstring. Thoughts?

To what extent is this about assign_coords vs the DataArray & Dataset constructor? Are there any differences between passing something to each of those?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   499988033