issue_comments: 732208262

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4577#issuecomment-732208262 https://api.github.com/repos/pydata/xarray/issues/4577 732208262 MDEyOklzc3VlQ29tbWVudDczMjIwODI2Mg== 35919497 2020-11-23T14:47:45Z 2020-11-24T06:48:10Z COLLABORATOR
  • I have replaced entrypoints with pkg_resources. I can't see any drawback in this change, but only advantages, the main one is that we remove an external dependency.
  • I have added the tests.
  • I didn't remove the signature inspection, since we have already talked about it widely with @shoyer, and in the end, we decided to keep the inspection and add the checks on the signature to be sure that neither args nor *kwargs will be used. 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   741714847