home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 727068025

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4574#issuecomment-727068025 https://api.github.com/repos/pydata/xarray/issues/4574 727068025 MDEyOklzc3VlQ29tbWVudDcyNzA2ODAyNQ== 14808389 2020-11-13T22:32:25Z 2020-11-13T22:49:49Z MEMBER

yeah, that makes the CI somewhat less useful. allow_failure is used for silencing the error code of pytest: https://github.com/pydata/xarray/blob/dd9fe2a8a414ddefa3b04b934163c9ccc628c5c7/ci/azure/unit-tests.yml#L14-L18

Not sure if that would make a difference, but maybe we should try using continueOnError instead?

Edit: we could also try to print a warning if the CI fails: yaml - bash: | $(environment_variables) pytest \ --junitxml=junit/test-results.xml \ --cov=xarray \ --cov-report=xml \ $(pytest_extra_flags) \ || ([ "$ALLOW_FAILURE" = "true" ] && echo -e "\043#vso[task.logissue type=warning;] ignored CI failure!!") see docs for the format of these messages. It seems they are supposed to be visible in the status report of github.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  741115905
Powered by Datasette · Queries took 7.492ms · About: xarray-datasette