home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 726921555

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4575#issuecomment-726921555 https://api.github.com/repos/pydata/xarray/issues/4575 726921555 MDEyOklzc3VlQ29tbWVudDcyNjkyMTU1NQ== 31640292 2020-11-13T17:57:48Z 2020-11-13T17:57:48Z CONTRIBUTOR

Yes, I think you could change

https://github.com/pydata/xarray/blob/b76a13f042571d01ca07461f13125a030f7297ea/xarray/core/formatting.py#L144

to np.issubdtype(x, np.floating) so it formats all floats.

This seems simple enough and fixes the main issue I was facing. I may look into the more extensible changes later if I have time, they would still be nice to have.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  741200389
Powered by Datasette · Queries took 0.81ms · About: xarray-datasette