issue_comments: 725795622

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4574#issuecomment-725795622 https://api.github.com/repos/pydata/xarray/issues/4574 725795622 MDEyOklzc3VlQ29tbWVudDcyNTc5NTYyMg== 5635139 2020-11-12T02:53:43Z 2020-11-12T02:53:43Z MEMBER

When thinking about this after we ended the call, I realized we would actually be losing a bit of coverage: what happens if we remove the upstream-dev CI for PRs and a PR introduces changes incompatible with upstream-dev? We would definitely catch that using the nightly CI, but only after merging.

That's a good point. A "allowed failure" would be even better.

Though on balance, assuming we can't do "allowed failures", I would favor more accurate test results over the immediacy of broken tests on upstream deps + new code. I'm not sure there are that many failures in the intersection of upstream deps + new code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   741115905