home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 721276226

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4560#issuecomment-721276226 https://api.github.com/repos/pydata/xarray/issues/4560 721276226 MDEyOklzc3VlQ29tbWVudDcyMTI3NjIyNg== 5635139 2020-11-03T17:37:18Z 2020-11-03T17:37:18Z MEMBER

Hi @dionhaefner ! Thanks for the PR; we're happy to have you as a contributor.

The code looks good. I think it's fairly obviously quicker at least for larger arrays. If you'd be up for writing an asv, that would give us confidence and prevent regressions.

Would you like to add a note to whatsnew?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  735199603
Powered by Datasette · Queries took 0.759ms · About: xarray-datasette