home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 720166781

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4559#issuecomment-720166781 https://api.github.com/repos/pydata/xarray/issues/4559 720166781 MDEyOklzc3VlQ29tbWVudDcyMDE2Njc4MQ== 14314623 2020-11-01T23:11:51Z 2020-11-01T23:11:51Z CONTRIBUTOR

I did have to fiddle with this a bit. I did change .isnull() to np.isnan() and replace the data of weights, otherwise the error would not be raised for the dask array at all. This does not look terribly elegant to me, but passes tests locally. Waiting for the CI to see if the others pass aswell. Happy to make further changes, and thanks for all the input already.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  733789095
Powered by Datasette · Queries took 0.7ms · About: xarray-datasette