issue_comments: 715958475

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4228#issuecomment-715958475 https://api.github.com/repos/pydata/xarray/issues/4228 715958475 MDEyOklzc3VlQ29tbWVudDcxNTk1ODQ3NQ== 15890747 2020-10-24T16:04:36Z 2020-10-24T16:04:36Z CONTRIBUTOR

Hi, I tried to work on this issue. I made the changes on the fix_#4228 branch of my fork (all in this commit).

Unfortunately I can't currently reproduce the full test environment. I am running python through the standard release and not anaconda/miniconda, and I am hesitant to install it alongside my current setup because that has caused some issues in the past. Simply installing pytest in my environment did allow me to run some tests (4031 passed, 4237 skipped, 66 xfailed, 15 xpassed, 41 warnings). Most notably the edited test ran successfully (i.e. pass on fresh pull, fail after I updated the test, pass again after I updated code).

Please let me know if that's good enough to open a pull request and ask for a review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   657466413