issue_comments: 714146475

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4516#issuecomment-714146475 https://api.github.com/repos/pydata/xarray/issues/4516 714146475 MDEyOklzc3VlQ29tbWVudDcxNDE0NjQ3NQ== 6628425 2020-10-22T01:30:25Z 2020-10-22T01:30:25Z MEMBER

Thanks @topper-123 -- I see you also made https://github.com/pandas-dev/pandas/pull/37321, making Index._id optional again, which I appreciate!

We do rely on private attributes in some places, but we're typically cautious about doing that, because their behavior can change without warning. For instance, in this case pandas-dev/pandas#37087 would have been a breaking change in a different way, since _reset_identity went from returning an Index, to operating on the Index in place.

Looking at the history of pandas.Index, it generally seems like outside the recent change, _reset_identity has been pretty stable over the years, though we'd still need to mull over the trade-off between the performance benefit and the robustness of the subclass to changes in pandas.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   723181209