issue_comments: 712066302

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4428#issuecomment-712066302 https://api.github.com/repos/pydata/xarray/issues/4428 712066302 MDEyOklzc3VlQ29tbWVudDcxMjA2NjMwMg== 1312546 2020-10-19T11:08:13Z 2020-10-19T11:43:46Z MEMBER

Sorry, my comment in https://github.com/pydata/xarray/issues/4428#issuecomment-711034128 was incorrect in a couple ways

  1. We still do the splitting, even when slicing with an out-of-order indexer. Checking on if that's appropriate.
  2. I'm checking in on a logic bug when computing the number of chunks. I don't think we properly handle non-uniform chunking on the other axes.
 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   702646191