issue_comments: 711461331

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4473#issuecomment-711461331 https://api.github.com/repos/pydata/xarray/issues/4473 711461331 MDEyOklzc3VlQ29tbWVudDcxMTQ2MTMzMQ== 1217238 2020-10-19T01:30:48Z 2020-10-19T01:30:48Z MEMBER
  • What's the best way of reconstituting the coords etc, after npg produces the array?

I think we can reuse the existing logic from the _combine method here: https://github.com/pydata/xarray/blob/97e26257e81b0ba35af4a34be43a3e9cc666b9bc/xarray/core/groupby.py#L830

This just gives us an alternative way to calculate applied.

  • Presumably we're going to have a fairly different design for this than the existing groupby operations — that design is very nested — wrapping functions and eventually calling .map to loop over each group in python.

Agreed. Hopefully this can live alongside in the GroupBy objects.

  • Presumably we're going to need to keep the existing logic around for dask — is it reasonable for an initial version to defer to the existing logic for all dask arrays? (+ @shoyer 's thoughts above on this)

Yes, I agree that we should do this incrementally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   711626733