home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 708088129

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4482#issuecomment-708088129 https://api.github.com/repos/pydata/xarray/issues/4482 708088129 MDEyOklzc3VlQ29tbWVudDcwODA4ODEyOQ== 5635139 2020-10-14T00:50:40Z 2020-10-14T00:50:40Z MEMBER

Right — that makes sense now. Given that .fillna(0) creates a copy, when we're doing stride tricks in the form of construct then that copy can be huge.

So I think there's a spectrum of implementations of skipna, o/w two are: - as a convenient alias of .fillna(0), like @mathause 's example above IIUC - ensuring a copy isn't made, which may require diving into np.einops (or open to alternatives)

The second would be required for @heerad 's case above

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  713834297
Powered by Datasette · Queries took 157.969ms · About: xarray-datasette