home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 706640485

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4501#issuecomment-706640485 https://api.github.com/repos/pydata/xarray/issues/4501 706640485 MDEyOklzc3VlQ29tbWVudDcwNjY0MDQ4NQ== 1053153 2020-10-11T02:37:00Z 2020-10-11T02:37:00Z CONTRIBUTOR

I'm not a huge fan of adding arguments for a case that rarely comes up (I presume). 

One difference in your example is that the 'e' coord is never based on 'y', so I would not want it expanded -- so I'd still like that test to pass.

The case I'm interested in is where the non-dimension coords are based on existing dimension coords that gets squeezed.

So in this example: ``` import numpy as np import xarray as xr

arr1 = xr.DataArray(np.zeros((1,5)), dims=['y', 'x'], coords={'y': [42], 'e': ('y', [10])}) arr1.squeeze() ```

The squeezed array looks like:

<xarray.DataArray (x: 5)> array([0., 0., 0., 0., 0.]) Coordinates: y int64 42 e int64 10 Dimensions without coordinates: x

What I think would be more useful:

<xarray.DataArray (x: 5)> array([0., 0., 0., 0., 0.]) Coordinates: y int64 42 e (y) int64 10 <---- Note the (y) Dimensions without coordinates: x

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  718716799
Powered by Datasette · Queries took 0.977ms · About: xarray-datasette