home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 698670864

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4454#issuecomment-698670864 https://api.github.com/repos/pydata/xarray/issues/4454 698670864 MDEyOklzc3VlQ29tbWVudDY5ODY3MDg2NA== 6628425 2020-09-25T01:30:05Z 2020-09-25T23:56:23Z MEMBER

You're absolutely right @andrewpauling -- pandas currently doesn't seem to have overflow protection in the case of casting timedelta64 types. I wrongly assumed that it would! I went ahead and opened an issue there: https://github.com/pandas-dev/pandas/issues/36615. We'll see what they say.

For now maybe you can add the test and attach an expected failure decorator to it?

In researching this, I came across https://github.com/numpy/numpy/issues/16352; if that eventually gets addressed this might all be moot.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  707745196
Powered by Datasette · Queries took 0.653ms · About: xarray-datasette