issue_comments: 696423669

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4427#issuecomment-696423669 https://api.github.com/repos/pydata/xarray/issues/4427 696423669 MDEyOklzc3VlQ29tbWVudDY5NjQyMzY2OQ== 6628425 2020-09-21T23:00:54Z 2020-09-21T23:04:56Z MEMBER

That would be great @andrewpauling! I think this is the relevant code in xarray: https://github.com/pydata/xarray/blob/1155f5646e07100e4acda18db074b148f1213b5d/xarray/core/variable.py#L244-L250

I want to say arguably we could use the _possibly_convert_objects function on datetime64 and timedelta64 data as well; you'll see this goes through a pandas.Series to do the casting, which has built-in logic to check that the values can be represented with nanosecond precision. But it's up to you how you ultimately want to go about things.

I agree this casting behavior is a bit surprising. If we wanted to be a little more transparent, we could also warn when attempting to cast non-nanosecond-precision datetime64 data to nanosecond precision. I'm not sure what others think; I know pandas doesn't do this, but it could be friendlier for users.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   702373263