issue_comments: 694817581

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4432#issuecomment-694817581 https://api.github.com/repos/pydata/xarray/issues/4432 694817581 MDEyOklzc3VlQ29tbWVudDY5NDgxNzU4MQ== 1312546 2020-09-18T11:36:49Z 2020-09-18T11:36:49Z MEMBER

I'm not sure, but I don't think so. It's strange that it didn't fail on the pull request.

On Thu, Sep 17, 2020 at 8:51 PM Maximilian Roos notifications@github.com wrote:

Might be best to proceed with #4434 https://github.com/pydata/xarray/pull/4434 for now. I'll need to give this a bit of thought.

OK, as you wish, I'll merge if that passes.

But your change did pass before the merge. Could it be a conflict (in functionality, not git) with recent changes on master?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/4432#issuecomment-694601049, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAOISNY5A5N2A44YR2ZMLSGK4JTANCNFSM4RQ6OP2Q . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   703881154