home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 690885702

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4187#issuecomment-690885702 https://api.github.com/repos/pydata/xarray/issues/4187 690885702 MDEyOklzc3VlQ29tbWVudDY5MDg4NTcwMg== 1217238 2020-09-11T05:35:29Z 2020-09-11T05:35:29Z MEMBER

Just to note down a few things:

  1. The deprecated "auto_chunk" kwarg was removed
  2. open_zarr uses chunks="auto" by default, whereas open_dataset uses chunks=None (see my comment inline)

The different default chunk behaviour (point 2) is worth raising, and it might be best to postpone the deprecation of open_zarr until the next release, so that there's time to discuss what we want the default setting to be (None or auto).

These all sound good to me!

I agree that we shouldn't change the default behavior for open_dataset, and should keep open_zarr around for now -- there is no urgent need to deprecate it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  647804004
Powered by Datasette · Queries took 0.638ms · About: xarray-datasette