home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 689770846

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4120#issuecomment-689770846 https://api.github.com/repos/pydata/xarray/issues/4120 689770846 MDEyOklzc3VlQ29tbWVudDY4OTc3MDg0Ng== 5635139 2020-09-09T19:30:42Z 2020-09-09T19:30:42Z MEMBER

Also, I think _replace is a bit confusing: the name seems to imply a inplace operation, but it returns a new object without changing the original object.

I think this mea culpa IIRC... I would be very open to consolidating this and .copy into something that returns a (generally shallow) copy of the object with some optional replacements. (The general approach is better than calling a constructor with every attribute, even if the names are not great)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  630062936
Powered by Datasette · Queries took 241.28ms · About: xarray-datasette