issue_comments: 687844137

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4392#issuecomment-687844137 https://api.github.com/repos/pydata/xarray/issues/4392 687844137 MDEyOklzc3VlQ29tbWVudDY4Nzg0NDEzNw== 5821660 2020-09-06T17:09:00Z 2020-09-06T17:09:00Z MEMBER

I think my latest changes according to @dcherian's comments are now backwards compatible. Short explanation:

  • allow_rechunk is None (default)
    • if core dimension chunks > 1 raise ValueError (to keep backward compatibility concerning core dimension chunking)
    • else sets allow_rechunk=True (to keep backward compatibility concerning chunking mismatch in non-core dimensions
  • allow_rechunk == True (user need to explicitoly set this in the dask_gufunc_kwargs)
    • just call apply_gufunc
  • allow_rechunk == False (user need to explicitoly set this in the dask_gufunc_kwargs)
    • just call apply_gufunc
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   688993462