issue_comments: 681103837

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4379#issuecomment-681103837 https://api.github.com/repos/pydata/xarray/issues/4379 681103837 MDEyOklzc3VlQ29tbWVudDY4MTEwMzgzNw== 14808389 2020-08-26T20:22:55Z 2020-08-26T20:22:55Z MEMBER

thanks for tracking this down. The easiest way to fix the test would be to decorate it with python pytest.mark.skipif(not IS_NEP18_ACTIVE, reason="requires NEP18") Even easier would be to bump numpy, but that doesn't seem to be possible right now.

We might also try to rewrite the condition to: python if ( hasattr(data, "__array_function__") or isinstance(data, dask_array_type) or (not IS_NEP18_ACTIVE and isinstance(data, np.ndarray)) ): data = copy.deepcopy(data)

Thoughts, @pydata/xarray?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   686495257