home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 681097210

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4379#issuecomment-681097210 https://api.github.com/repos/pydata/xarray/issues/4379 681097210 MDEyOklzc3VlQ29tbWVudDY4MTA5NzIxMA== 6875882 2020-08-26T20:08:43Z 2020-08-26T20:08:43Z CONTRIBUTOR

Oh, sorry, I actually can reproduce it locally.

Turns out arrays in numpy 1.15 don't have __array_function__. So this:

python if deep: if hasattr(data, "__array_function__") or isinstance( data, dask_array_type ): data = copy.deepcopy(data) elif not isinstance(data, PandasIndexAdapter): # pandas.Index is immutable data = np.array(data)

could just be

python if deep and not isinstance(data, PandasIndexAdapter): data = copy.deepcopy(data)

But I'm not familiar with __array_function__ or why it's being used here, any thoughts?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  686495257
Powered by Datasette · Queries took 79.888ms · About: xarray-datasette