issue_comments: 676547072

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4237#issuecomment-676547072 https://api.github.com/repos/pydata/xarray/issues/4237 676547072 MDEyOklzc3VlQ29tbWVudDY3NjU0NzA3Mg== 14808389 2020-08-19T17:02:55Z 2020-08-20T00:29:01Z MEMBER

does anyone have any advice on how to add multiple fill value support to fillna? It is currently using ops.fillna which uses apply_ufunc with duck_array_ops.fillna: https://github.com/pydata/xarray/blob/d9ebcafaddf0bb80052d30f43ca5ea18a5c7229f/xarray/core/ops.py#L137-L171 but that obviously only works for data variables.

To fix that, I would manually apply duck_array_ops.fillna to data variables and coordinates and then reassemble the dataset (using _to_temp_dataset / _from_temp_dataset for DataArray), but since I don't really understand apply_ufunc I'm not sure what that would break.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   659232211