home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 676539274

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4314#issuecomment-676539274 https://api.github.com/repos/pydata/xarray/issues/4314 676539274 MDEyOklzc3VlQ29tbWVudDY3NjUzOTI3NA== 5635139 2020-08-19T16:47:02Z 2020-08-19T16:47:02Z MEMBER

I just saw I was up for reviewing this — sorry for missing that.

Looks good. @keewis 's suggestion for the back-compat code looks like a nice refinement — it includes a version check which will ease disentangling it. Could we add that and then merge?

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  673757961
Powered by Datasette · Queries took 0.725ms · About: xarray-datasette