issue_comments: 674153884

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4193#issuecomment-674153884 https://api.github.com/repos/pydata/xarray/issues/4193 674153884 MDEyOklzc3VlQ29tbWVudDY3NDE1Mzg4NA== 20629530 2020-08-14T16:23:12Z 2020-08-14T16:23:35Z CONTRIBUTOR

So while adding tests, I realized there were more bugs concerning deficient rank matrices and full=True output. I believe I fixed all I could find. However, I was not able to reduce the number of warnings for the case using dask : the computation occurs outside of the catch_warnings() context... Also, there is a bug in the dask.array.linalg.lstsq output (see issue dask/dask#6516), so if full=True we must use skipna=True with dask. Same when rank != order (deficient rank), dask.array.linalg.lstsq will fail, so we work around by using our (slower) nan-skipping method.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   650044968