issue_comments: 673978057

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4193#issuecomment-673978057 https://api.github.com/repos/pydata/xarray/issues/4193 673978057 MDEyOklzc3VlQ29tbWVudDY3Mzk3ODA1Nw== 10194086 2020-08-14T09:15:15Z 2020-08-14T09:15:15Z MEMBER

Overall, it feels a bi ugly because of the duplicated code

Looks fine to me.

and it will print the warning for every line of an array that has a deficient rank, which can be a lot...

That could be annoying as a user. This happens in results = da.apply_along_axis(nputils._nanpolyfit_1d, ...), right? Can you use a warnings.simplefilter("once") so the error is only issued once - something along the lines of:

python with warnings.catch_warnings(): warnings.simplefilter("once", np.RankWarning) results = da.apply_along_axis( nputils._nanpolyfit_1d, ... )

I think this also warrants tests and a whats-new entry.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   650044968