issue_comments: 670705764

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4219#issuecomment-670705764 https://api.github.com/repos/pydata/xarray/issues/4219 670705764 MDEyOklzc3VlQ29tbWVudDY3MDcwNTc2NA== 6815844 2020-08-07T20:45:01Z 2020-08-07T20:45:01Z MEMBER

Thanks @max-sixty .

You are completely correct. As the test pass, I was fooling myself.

The reason was that the dataset I was using for the test does not have time and x simultaneously. So I was not testing the 2d-rolling but just 1d-rolling.

Fixed. Now it correctly fails for mean and std, but passes with max and sum

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   655389649