home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 670248276

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4314#issuecomment-670248276 https://api.github.com/repos/pydata/xarray/issues/4314 670248276 MDEyOklzc3VlQ29tbWVudDY3MDI0ODI3Ng== 5635139 2020-08-06T23:59:16Z 2020-08-06T23:59:16Z MEMBER

I'm fine with reraising — though I think we should reraise, otherwise isn't it a confusing message?

The try-expect is probably fine given the narrowness (very open to holding too low a standard tho); one step up would be checking it is a spare array.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  673757961
Powered by Datasette · Queries took 0.519ms · About: xarray-datasette