issue_comments: 669599057

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4314#issuecomment-669599057 https://api.github.com/repos/pydata/xarray/issues/4314 669599057 MDEyOklzc3VlQ29tbWVudDY2OTU5OTA1Nw== 13837821 2020-08-05T23:37:07Z 2020-08-05T23:37:07Z CONTRIBUTOR

Thanks @max-sixty. I pushed a second commit, including adding a keep_attrs argument so people can keep the old behavior of losing the attrs. I added a bit more testing on for general astype behavior, checking dtypes are correct and values are similar.

What do you make of the failing tests in test_sparse.py (test_dataarray_method and test_variable_method)? I'm not really familiar enough with the pytest parametrize syntax to figure out what's going on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   673757961