home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 669033339

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4310#issuecomment-669033339 https://api.github.com/repos/pydata/xarray/issues/4310 669033339 MDEyOklzc3VlQ29tbWVudDY2OTAzMzMzOQ== 226037 2020-08-05T07:34:41Z 2020-08-05T07:36:49Z MEMBER

@shoyer & @jhamman you can merge the PR as it is (safest and my preferred option) or if you prefer to have also option 2. I can easily implement it in this PR by adding contextlib.closing to with-statements in the tests.

Option 3. needs a bit more discussion and I would open a different PR for that.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  673061269
Powered by Datasette · Queries took 0.882ms · About: xarray-datasette