home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 668401159

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4295#issuecomment-668401159 https://api.github.com/repos/pydata/xarray/issues/4295 668401159 MDEyOklzc3VlQ29tbWVudDY2ODQwMTE1OQ== 1217238 2020-08-04T06:13:36Z 2020-08-04T06:13:36Z MEMBER

I'm not here to argue, but pyproject.toml was introduced in PEP-518, which was accepted over 4 years ago. I know packaging moves slowly but I'm curious how long something has to be around before becoming "established" and ceases to be "novel". 😉

It looks like pip has supported pyproject.toml since version 10.0.0, on 2018-04-14. That's more recent than Python 3.6 (which, to be fair, we are about to drop support for).

Consistent with my earlier suggestion about setuptools, I think we should support the oldest packaging tools that were released at the time of our earliest supported Python release. So if we switch to requiring Python 3.7 in our next major release, we could switch to using pyproject.toml, too.

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  671019427
Powered by Datasette · Queries took 240.382ms · About: xarray-datasette