issue_comments: 666546137

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4290#issuecomment-666546137 https://api.github.com/repos/pydata/xarray/issues/4290 666546137 MDEyOklzc3VlQ29tbWVudDY2NjU0NjEzNw== 35968931 2020-07-30T17:29:43Z 2020-07-30T17:29:43Z MEMBER

This question seems to me to be conceptually similar to the question I described in #3315: "Should we treat a named DataArray and a single-variable Dataset as if they are the same?"

If the answer is yes, then we should definitely change the behaviour of bool(Dataset()) as Aaron suggests. If instead we decide "no, Datasets are dictionaries of DataArrays, and a single-element dictionary is not the same thing as the named object it contains", then I'm not sure.

Intuitively I personally think it should be the former, but I would first like to see how many tests break if we make that kind of change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   668717850