home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 663778598

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4237#issuecomment-663778598 https://api.github.com/repos/pydata/xarray/issues/4237 663778598 MDEyOklzc3VlQ29tbWVudDY2Mzc3ODU5OA== 14808389 2020-07-25T00:03:11Z 2020-07-25T00:03:11Z MEMBER

apply_ufunc turns out to be way too complicated for me to change it without understanding most of the code, so I guess we should postpone that until someone needs multiple fill values on dataset objects?

I think fillna should allow filling coordinates (both dimension and non-dimension coordinates), but the current implementation simply uses apply_ufunc with duck_array_ops.fillna, so I'm not sure how to support that.

Same for idxmin and idxmax: they use Dataset.map or call the computation function directly, so we'd need to rewrite those functions to get fill values.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  659232211
Powered by Datasette · Queries took 2.08ms · About: xarray-datasette