issue_comments: 661958330

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4155#issuecomment-661958330 https://api.github.com/repos/pydata/xarray/issues/4155 661958330 MDEyOklzc3VlQ29tbWVudDY2MTk1ODMzMA== 1005109 2020-07-21T16:17:08Z 2020-07-21T16:17:08Z CONTRIBUTOR

Thanks, @pums974 for this update. I left some comments.

Can you add some tests for more edge cases? Something we may want to check would be

* scalar interpolation
* interpolation into an unsorted dimension (e.g., `da.interp(x=[0, 3, 2])`)

Your welcome, thanks for the feedback

  • scalar interpolation: you mean a test like test_interpolate_nd_scalar but between chunks ?
  • Unsorted interpolation: As I said, I did not looked into it, This need some work, presumably an argsort at the begining in order to interpolate in a sorted dimension and reorder the result into the requested order. I'm trying to implement it, but this seems a bit more challenging than I thought.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   638909879