issue_comments: 660148433
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/issues/4234#issuecomment-660148433 | https://api.github.com/repos/pydata/xarray/issues/4234 | 660148433 | MDEyOklzc3VlQ29tbWVudDY2MDE0ODQzMw== | 1610850 | 2020-07-17T14:48:01Z | 2020-07-17T14:54:41Z | CONTRIBUTOR | This does sound like an option. However there are many situations within xarray where we need explicit cupy logic. Converting back to numpy before plotting is one example. I don't think that kind of logic can live in an accessor. Unless you expect users to do something like this. ```python import xarray as xr import cupy as cp ds = xr.tutorial.load_dataset("air_temperature") gds = ds.cupy.to_cupy() Do some manipulation on the GPUGrab a time slicetime_slice = gds.air.isel(time=0) time_slice.cupy.to_numpy().plot() # I would hope that time_slice.plot() would work ``` I would be tempted to say that cupy is more like dask in that it is trying to implement the numpy array interface exactly but in a different paradigm (distributed, GPU, etc). And of course there are limitations and divergences because of the different paradigm. However it's not the same as pint which is trying to extend numpy and add more functionality. So it makes sense to me that accessors for pint exist to add this extra functionality to xarray. But at least in theory cupy should be a drop-in replacement for numpy. So I don't expect a huge amount of logic will live in an accessor, compared to the amount of compatibility code that will need to go into xarray itself. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
659129613 |