home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 658946116

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4221#issuecomment-658946116 https://api.github.com/repos/pydata/xarray/issues/4221 658946116 MDEyOklzc3VlQ29tbWVudDY1ODk0NjExNg== 19578931 2020-07-15T19:01:17Z 2020-07-15T19:01:17Z CONTRIBUTOR

I'm getting a bit lost within the testing suite while trying to figure out the implications of this change and what kinds of tests are necessary for it. Would a test module for this - Individually test all functions that include the newly implemented is_duck_dask_array()? - Test that a duck dask Array has attributes of a dask Array and redirects the appropriate methods to those defined by Variable, DataArray, and Dataset? - Be similar to test_dask.py? - All, some, or none of the above?

Any suggestions would be greatly appreciated.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  656163384
Powered by Datasette · Queries took 0.491ms · About: xarray-datasette