home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 658130892

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4221#issuecomment-658130892 https://api.github.com/repos/pydata/xarray/issues/4221 658130892 MDEyOklzc3VlQ29tbWVudDY1ODEzMDg5Mg== 14808389 2020-07-14T11:37:23Z 2020-07-14T11:37:23Z MEMBER

Revisiting it I now realize that is_array_like is actually not a good name for that function: officially, "array_like" means that it can be casted using np.asarray. Maybe we should rename that to is_duck_array? But then we'd also need to check for __array_ufunc__ and __array_function__ because we also need those to properly wrap duck arrays.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  656163384
Powered by Datasette · Queries took 79.828ms · About: xarray-datasette