issue_comments: 657270068

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4219#issuecomment-657270068 https://api.github.com/repos/pydata/xarray/issues/4219 657270068 MDEyOklzc3VlQ29tbWVudDY1NzI3MDA2OA== 6815844 2020-07-12T20:18:28Z 2020-07-12T20:18:28Z MEMBER

Another API concern. We now use min_periods, in which we implicitly assume one-dimension cases.

With nd-dimension, I think min_counts argument is more appropriate like bottleneck, which will limit the lower bound of the number of missing entries in the n-dimensional window.

Even if we leave it, we may disallow nd-argument of min_periods but keep it a scalar.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   655389649